Attention is currently required from: Dinesh Gehlot, Emilie Roberts, John Su, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Won Chung.
Emilie Roberts has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81354?usp=email )
Change subject: mb/google/brya: Fix mux_conn index used by ec/google/chromeec
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81354/comment/c4432145_0b72fff6 :
PS4, Line 24: TEST=emerge-${BOARD} coreboot then check ACPI table on DUT
Please document the commands how to check for the relevant things.
I added the manual check. Unfortunately the usbpd lines are needed on some devices who have not yet finished quals for a superspeed line firmware patch.
Patchset:
PS4:
Will do, have been unable to confirm on remote hardware. […]
Tested on felwinter and mithrax.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81354?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I349682a6fe3fe4848e4e86d9c446530a31b35875
Gerrit-Change-Number: 81354
Gerrit-PatchSet: 5
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Emilie Roberts
hadrosaur@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benson Leung
bleung@google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prashant Malani
pmalani@chromium.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Emilie Roberts
hadrosaur@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Won Chung
wonchung@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 30 Apr 2024 14:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Comment-In-Reply-To: Emilie Roberts
hadrosaur@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Won Chung
wonchung@google.com
Gerrit-MessageType: comment