Ivan Labáth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39082 )
Change subject: Documentation: getting_started/gpio.md - fix quotes ......................................................................
Documentation: getting_started/gpio.md - fix quotes
Change-Id: I2c61770d60a4f290fd8d516850f16bc3808ad48d Signed-off-by: Ivan Labáth iger@labo.rs --- M Documentation/getting_started/gpio.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39082/1
diff --git a/Documentation/getting_started/gpio.md b/Documentation/getting_started/gpio.md index 26939ce..81a06eb 100644 --- a/Documentation/getting_started/gpio.md +++ b/Documentation/getting_started/gpio.md @@ -25,7 +25,7 @@ based on a baseboard/variant model, where several variant mainboards may share a lot of their circuitry and ICs and the commonality between the boards is collected into a virtual ``baseboard.`` In that case, the GPIOs which are shared -between multiple boards are placed in the baseboard's ``gpio.c` file, while the +between multiple boards are placed in the baseboard's ``gpio.c`` file, while the ones that are board-specific go into each variant's ``gpio.c`` file.
## Intel SoCs
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39082
to look at the new patch set (#2).
Change subject: Documentation: getting_started/gpio.md: fix markup ......................................................................
Documentation: getting_started/gpio.md: fix markup
Change-Id: I2c61770d60a4f290fd8d516850f16bc3808ad48d Signed-off-by: Ivan Labáth iger@labo.rs --- M Documentation/getting_started/gpio.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39082/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39082 )
Change subject: Documentation: getting_started/gpio.md: fix markup ......................................................................
Patch Set 2: Code-Review+1
I thought it’s only one backtick in Markdown, that means `code`.
Ivan Labáth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39082 )
Change subject: Documentation: getting_started/gpio.md: fix markup ......................................................................
Patch Set 2:
I thought it’s only one backtick in Markdown, that means `code`.
It seems single backtick version is prevalent in the documentation, with double-backtick appearing only in 5 files:
security/intel/acm.md security/intel/txt.md arch/x86/pae.md getting_started/gpio.md acpi/devicetree.md
AFAICT it looks the same. I can add a patch to change the few double ticks to single ticks, but note, that I haven't actually tried building the documentation - I only noticed it was broken and made a simple fix.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39082 )
Change subject: Documentation: getting_started/gpio.md: fix markup ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39082 )
Change subject: Documentation: getting_started/gpio.md: fix markup ......................................................................
Documentation: getting_started/gpio.md: fix markup
Change-Id: I2c61770d60a4f290fd8d516850f16bc3808ad48d Signed-off-by: Ivan Labáth iger@labo.rs Reviewed-on: https://review.coreboot.org/c/coreboot/+/39082 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/getting_started/gpio.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/Documentation/getting_started/gpio.md b/Documentation/getting_started/gpio.md index 26939ce..81a06eb 100644 --- a/Documentation/getting_started/gpio.md +++ b/Documentation/getting_started/gpio.md @@ -25,7 +25,7 @@ based on a baseboard/variant model, where several variant mainboards may share a lot of their circuitry and ICs and the commonality between the boards is collected into a virtual ``baseboard.`` In that case, the GPIOs which are shared -between multiple boards are placed in the baseboard's ``gpio.c` file, while the +between multiple boards are placed in the baseboard's ``gpio.c`` file, while the ones that are board-specific go into each variant's ``gpio.c`` file.
## Intel SoCs
-
Ivan Labáth (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)