Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86013?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in ramstage
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/common/include/soc/memlayout.h:
https://review.coreboot.org/c/coreboot/+/86013/comment/d6b1fce1_5b79b9c6?usp... :
PS1, Line 24: #define FSP_INIT_CODE(addr, size) \
Just remove
I am wrong. The region is served to run the binary. Please ignore my comment.
File src/soc/mediatek/mt8196/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/86013/comment/4e215786_648b8023?usp... :
PS1, Line 67: FSP_INIT_CODE(0x90000000, 2M)
not needed
Ignore this comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86013?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia73d241694ca9a4686bf4b0533c51a663a765c21
Gerrit-Change-Number: 86013
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 01:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com