[S] Change in coreboot[main]: sb/intel/bd82x6x/early_usb: Add USB TX/RX gains - coreboot-gerrit

10 Jan 2024


      Attention is currently required from: Keith Hui, Patrick Rudolph, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78829?usp=email )
Change subject: sb/intel/bd82x6x/early_usb: Add USB TX/RX gains
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/southbridge/intel/bd82x6x/early_usb.c:
https://review.coreboot.org/c/coreboot/+/78829/comment/456ad2e1_b57f0b8e :
PS10, Line 41: portmap[i].current
It would be nice to have a more meaningful name with an enum to use in devicetree.c similar to the ones you introduce. Could a be follow-up.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78829?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79d35ca16818daec03ee7f464349a4c8ee0f78e4
Gerrit-Change-Number: 78829
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 10 Jan 2024 15:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment