Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63030 )
Change subject: checkpatch.conf: Disable gerrit change ID for coreboot ......................................................................
checkpatch.conf: Disable gerrit change ID for coreboot
The GERRIT_CHANGE_ID Error is useful for the linux flow, but since coreboot uses gerrit, giving an error on the ID doesn't make sense.
Change-Id: I7f6efb5559027ed9497ee85497bb4b4e786f9901 Signed-off-by: Martin Roth martin@coreboot.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/63030 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Elyes Haouas ehaouas@noos.fr Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Subrata Banik subratabanik@google.com --- M .checkpatch.conf 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, but someone else must approve Felix Singer: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved
diff --git a/.checkpatch.conf b/.checkpatch.conf index 95019d1..dbb1aaa 100644 --- a/.checkpatch.conf +++ b/.checkpatch.conf @@ -22,6 +22,7 @@ --ignore PRINTK_WITHOUT_KERN_LEVEL --ignore ASSIGN_IN_IF --ignore UNNECESSARY_ELSE +--ignore GERRIT_CHANGE_ID
# FILE_PATH_CHANGES seems to not be working correctly. It will # choke on added / deleted files even if the MAINTAINERS file
-
Martin Roth (Code Review)