Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45038 )
Change subject: soc/intel/apollolake: Select CPU_INTEL_COMMON ......................................................................
soc/intel/apollolake: Select CPU_INTEL_COMMON
This is an intermediate step to have SOC_INTEL_COMMON_BLOCK_CPU select CPU_INTEL_COMMON directly, to avoid dependency problems.
Tested with BUILD_TIMELESS=1, UP Squared does not change. Gemini Lake already selects this through SOC_INTEL_COMMON_BLOCK_SGX.
Change-Id: If737fa6d8700f435c8692c80244f0e71657c2236 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/apollolake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/45038/1
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 964e7d4..96808cf 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -28,6 +28,7 @@ select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES # CPU specific options + select CPU_INTEL_COMMON select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select IOAPIC select PCR_COMMON_IOSF_1_0
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45038 )
Change subject: soc/intel/apollolake: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1:
does it support VMX?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45038 )
Change subject: soc/intel/apollolake: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1:
Patch Set 1:
does it support VMX?
CB:45039 hooks up the VmxEnable FSP UPD, and ENABLE_VMX is only available if CPU_INTEL_COMMON is selected.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45038 )
Change subject: soc/intel/apollolake: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45038 )
Change subject: soc/intel/apollolake: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
does it support VMX?
CB:45039 hooks up the VmxEnable FSP UPD, and ENABLE_VMX is only available if CPU_INTEL_COMMON is selected.
There is still SET_IA32_FC_LOCK_BIT left to hook up.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45038 )
Change subject: soc/intel/apollolake: Select CPU_INTEL_COMMON ......................................................................
soc/intel/apollolake: Select CPU_INTEL_COMMON
This is an intermediate step to have SOC_INTEL_COMMON_BLOCK_CPU select CPU_INTEL_COMMON directly, to avoid dependency problems.
Tested with BUILD_TIMELESS=1, UP Squared does not change. Gemini Lake already selects this through SOC_INTEL_COMMON_BLOCK_SGX.
Change-Id: If737fa6d8700f435c8692c80244f0e71657c2236 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45038 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/apollolake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 964e7d4..96808cf 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -28,6 +28,7 @@ select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES # CPU specific options + select CPU_INTEL_COMMON select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select IOAPIC select PCR_COMMON_IOSF_1_0
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)