Attention is currently required from: Bao Zheng, Marshall Dawson, Zheng Bao. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55602 )
Change subject: amdfwtool: Add more detailed description and note in comment ......................................................................
Patch Set 11:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55602/comment/4dfaee5a_fa238e77 PS11, Line 7: Add more detailed description and note in comment Maybe:
Update and extend PSP header format description
https://review.coreboot.org/c/coreboot/+/55602/comment/e5819d5a_689a544b PS11, Line 8: Why is the update needed? Was newer documentation released?
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/55602/comment/cc5645d7_39da404e PS11, Line 4: (*) What does this mean?
https://review.coreboot.org/c/coreboot/+/55602/comment/46e94746_7207288c PS11, Line 31: Firmwares I think plural is also *firmware*.
https://review.coreboot.org/c/coreboot/+/55602/comment/eaa5eb05_625799da PS11, Line 49: Firmwares Firmware
https://review.coreboot.org/c/coreboot/+/55602/comment/211ecb64_62a663d0 PS11, Line 53: BIOS Directory Table(BDT) Please add a space before the (.