Attention is currently required from: Nico Huber, Martin Roth, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 )
Change subject: payloads: FILO: Hook up autoboot options ......................................................................
Patch Set 2:
(3 comments)
File payloads/external/FILO/Makefile:
https://review.coreboot.org/c/coreboot/+/56213/comment/9aece3c3_247ebc42 PS1, Line 36: ifeq ($(CONFIG_FILO_USE_AUTOBOOT),y)
You stripped the `FILO_` when passing it to the inner Makefile.
Thanks, I updated `Makefile.inc`.
https://review.coreboot.org/c/coreboot/+/56213/comment/3fe920df_4f91a71c PS1, Line 39: FILO_
Same here.
Done
File payloads/external/FILO/Makefile:
https://review.coreboot.org/c/coreboot/+/56213/comment/d0583a67_6b9a10d5 PS2, Line 39: echo "CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE)" >> filo/.config That seems to work now, but it overridden later on:
``` echo "# CONFIG_USE_GRUB is not set" >> filo/.config echo "CONFIG_USE_AUTOBOOT=y" >> filo/.config echo "CONFIG_AUTOBOOT_FILE=hda1:/vmlinuz root=/dev/sda1 console=tty0 console=ttyS0,115200" >> filo/.config make -C filo oldconfig LIBCONFIG_PATH=../../../libpayload mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/drivers/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/fs/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/main/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/main/grub/ mkdir -p /dev/shm/coreboot/payloads/external/FILO/filo/build/x86/ echo "Using binary libpayload, nothing to configure" Using binary libpayload, nothing to configure /dev/shm/coreboot/payloads/external/FILO/filo/build/util/kconfig/conf -o Kconfig .config:74:warning: override: reassigning to symbol USE_GRUB * * FILO Configuration * Build for architecture
- x86 (TARGET_I386)
2. ARM (TARGET_ARM) choice[1-2]: 1 Include a MultiBoot header (MULTIBOOT_IMAGE) [Y/n/?] y * * Interface Options * Use GRUB like interface (USE_GRUB) [N/y/?] n non-interactive interface (NON_INTERACTIVE) [N/y/?] n Autoboot a command line after timeout? (USE_AUTOBOOT) [Y/n] y Kernel filename and parameters (AUTOBOOT_FILE) [hda1:/vmlinuz root=/dev/hda1 console=tty0 console=ttyS0,115200] ```