Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )
Change subject: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/#/c/18557/14/src/soc/intel/common/block/fast_spi...
File src/soc/intel/common/block/fast_spi/fast_spi.c:
Line 39: void get_bios_rom_region(size_t *bios_start, size_t *bios_end)
It's really clunky. Plus the function isn't namespaced with the module. All
will fix it in the next patch-set.
Line 56: void spi_flash_init(device_t dev)
fast_spi_flash_init(). all functions should be namespaced accordingly.
will fix it.
--
To view, visit
https://review.coreboot.org/18557
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 14
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes