Attention is currently required from: Nico Huber, Raul Rangel, Lee Leahy, Angel Pons, Huang Jin, Arthur Heymans, Patrick Rudolph, Felix Held.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54957 )
Change subject: drivers/intel/fsp1_1: Drop empty weak functions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
hm, not sure about the mainboard_ one
$ git grep -l mainboard_add_dimm_info
src/drivers/intel/fsp1_1/include/fsp/romstage.h
src/drivers/intel/fsp1_1/romstage.c
src/mainboard/scaleway/tagada/ramstage.c
src/soc/intel/denverton_ns/hob_mem.c
src/soc/intel/denverton_ns/include/soc/ramstage.h
tagada is the only mainboard and it's using denverton_ns which has its own flow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie60213e5a6ae67bd8b982ee505f4b512253577c6
Gerrit-Change-Number: 54957
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Huang Jin
huang.jin@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 26 May 2021 18:02:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment