Attention is currently required from: Paul Menzel, Angel Pons, Krystian Hebel.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 )
Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
......................................................................
Patch Set 11:
(2 comments)
File Documentation/drivers/cbfs_smbios.md:
https://review.coreboot.org/c/coreboot/+/64639/comment/7712f660_56b00ef0
PS10, Line 60: 2
`up to 2`
Done
File src/drivers/generic/cbfs-uuid/cbfs-uuid.c:
https://review.coreboot.org/c/coreboot/+/64639/comment/b3ead1df_2bfdd728
PS10, Line 18: obsolete
I'd replace "all obsolete characters" with "any trailing whitespace". […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf
Gerrit-Change-Number: 64639
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 06:41:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment