build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: drivers/ocp/dmi: Added OCP_DMI driver for populating SMBIOS from IPMI FRU data
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40308/15/src/drivers/ocp/dmi/smbios...
File src/drivers/ocp/dmi/smbios.c:
https://review.coreboot.org/c/coreboot/+/40308/15/src/drivers/ocp/dmi/smbios...
PS15, Line 164: snprintf(ppin, sizeof(ppin), "%x%x", xeon_sp_ppin[1].hi, xeon_sp_ppin[1].lo);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c958dfad83216cd12545760a19d205efc2515b
Gerrit-Change-Number: 40308
Gerrit-PatchSet: 15
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Apr 2020 10:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment