[XS] Change in coreboot[main]: acpi.c: Fix generating pointer to cb_tables located >4G - coreboot-gerrit

6 Oct 2023


      Attention is currently required from: Arthur Heymans, Benjamin Doron, Eric Lai, Felix Held, Lance Zhao, Maximilian Brune, Nico Huber.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76181?usp=email )
Change subject: acpi.c: Fix generating pointer to cb_tables located >4G
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Patchset:
PS2:
...
...
Agree with Nico. […]
That's right, I think this is probably the correct way to do it.
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76181/comment/d2487726_650f8352 :
PS4, Line 301: 	if (base < UINT32_MAX)
nit: `<=` ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76181?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1bc553b18d08cee502b765166227810f8e619631
Gerrit-Change-Number: 76181
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Oct 2023 15:15:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment