Change in coreboot[master]: soc/intel/common/block: Enable PMC IPC driver

[Brandon Breitenstein (Code Review)]

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )

Change subject: soc/intel/common/block: Enable PMC IPC driver
......................................................................

Patch Set 10:

(4 comments)

https://review.coreboot.org/c/coreboot/+/37871/7/src/soc/intel/common/block/... 
File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/37871/7/src/soc/intel/common/block/... 
PS7, Line 25: #include <soc/pm.h>
            : #include <stdint.h>
            : #include <string.h>
            : #include <timer.h>
            : #include <types.h>
            : #include <security/vboot/vboot_common.h>
> Will sort this was put in unsorted before the addition of the new includes (vboot_common was at bott […]

Done

https://review.coreboot.org/c/coreboot/+/37871/7/src/soc/intel/common/block/... 
PS7, Line 608: read32
> this is just reading the status register nothing is actually getting sent to PMC here. […]

Ack

https://review.coreboot.org/c/coreboot/+/37871/7/src/soc/intel/common/block/... 
PS7, Line 622: uint8_t
> const uint8_t *?

Done

https://review.coreboot.org/c/coreboot/+/37871/7/src/soc/intel/common/block/... 
PS7, Line 627: 4
> the maximum size for any PMC command is 4 hence using it here in case this needs to be expanded for  […]

Ack