Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68235 )
Change subject: mb/amd/bilby: Clean up includes ......................................................................
mb/amd/bilby: Clean up includes
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: Ieb4bf3e759605de92a9bcedbd595a9ce3f5fb17e --- M src/mainboard/amd/bilby/bootblock.c M src/mainboard/amd/bilby/early_gpio.c M src/mainboard/amd/bilby/emmc_gpio.c M src/mainboard/amd/bilby/gpio.c M src/mainboard/amd/bilby/hda_verb.c M src/mainboard/amd/bilby/mainboard.h 6 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/68235/1
diff --git a/src/mainboard/amd/bilby/bootblock.c b/src/mainboard/amd/bilby/bootblock.c index 94a1329..1847d86 100644 --- a/src/mainboard/amd/bilby/bootblock.c +++ b/src/mainboard/amd/bilby/bootblock.c @@ -1,8 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <bootblock_common.h> #include <amdblocks/lpc.h> +#include <bootblock_common.h> +#include <device/pnp_type.h> #include <superio/smsc/sio1036/sio1036.h> + #include "gpio.h"
#define SERIAL_DEV PNP_DEV(CONFIG_SUPERIO_ADDR_BASE, SIO1036_SP1) diff --git a/src/mainboard/amd/bilby/early_gpio.c b/src/mainboard/amd/bilby/early_gpio.c index 466b4fc..746b5c4 100644 --- a/src/mainboard/amd/bilby/early_gpio.c +++ b/src/mainboard/amd/bilby/early_gpio.c @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + +#include <commonlib/bsd/helpers.h> #include <soc/gpio.h> + #include "gpio.h"
/* GPIO pins used by coreboot should be initialized in bootblock */ diff --git a/src/mainboard/amd/bilby/emmc_gpio.c b/src/mainboard/amd/bilby/emmc_gpio.c index f72437b..a92b98d 100644 --- a/src/mainboard/amd/bilby/emmc_gpio.c +++ b/src/mainboard/amd/bilby/emmc_gpio.c @@ -1,6 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <commonlib/bsd/helpers.h> #include <soc/gpio.h> + #include "gpio.h"
/* eMMC controller driving either an SD card or eMMC device. */ diff --git a/src/mainboard/amd/bilby/gpio.c b/src/mainboard/amd/bilby/gpio.c index 18ee482..481a387 100644 --- a/src/mainboard/amd/bilby/gpio.c +++ b/src/mainboard/amd/bilby/gpio.c @@ -1,6 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <commonlib/bsd/helpers.h> #include <soc/gpio.h> + #include "gpio.h"
/* diff --git a/src/mainboard/amd/bilby/hda_verb.c b/src/mainboard/amd/bilby/hda_verb.c index 0f61f31..60d75fd 100644 --- a/src/mainboard/amd/bilby/hda_verb.c +++ b/src/mainboard/amd/bilby/hda_verb.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/azalia_device.h> +#include <stdint.h>
const u32 cim_verb_data[] = { /* Realtek ALC701 on mainboard */ diff --git a/src/mainboard/amd/bilby/mainboard.h b/src/mainboard/amd/bilby/mainboard.h index b58c350..d4f25c1 100644 --- a/src/mainboard/amd/bilby/mainboard.h +++ b/src/mainboard/amd/bilby/mainboard.h @@ -1,3 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <stdint.h> + int get_ddi_port_conn_type(uint8_t port_num);