Attention is currently required from: Ravi kumar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55378 )
Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN ......................................................................
Patch Set 42:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/55378/comment/3eaf21ec_22e8c9e6 PS42, Line 23: /* Assert EN_PP3300_HUB for those board variants that use it. */ : if (CONFIG(BOARD_GOOGLE_HEROBRINE)) { : gpio_output(USB_HUB_LDO_EN, 1); : } else { : gpio_output(USB_HUB_LDO_EN, 1); : } : This condition doesn't seem necessary anymore since the if and else conditions are exactly the same.