Attention is currently required from: Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57044 )
Change subject: ec/starlabs/it8987: Fix build warning
......................................................................
Patch Set 13:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57044/comment/e5a89a07_a36b5258
PS4, Line 9: Fix build warning when EC binary not included when it shouldn't be
: Make LID method compliant with SW_LID (Fixes two backlight controls)
: Remove power button device
: Add Kconfig option for including EC binary
Should I split CB:56088 too?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id16881fd7901a2eaafc6108676ff429fb71c3571
Gerrit-Change-Number: 57044
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 14 Sep 2021 09:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment