Attention is currently required from: Mario Scheithauer, Jan Samek.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 )
Change subject: mb/siemens/mc_ehl4: Adjust GPIOs ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
I might suggest mentioning also the GPIOs that have a default value or are NC. […]
I am not sure about this, Jan. If we want to have _all_ GPIOs mentioned in the tables then the tables will become quite long due to the vast amount of configurable GPIOS. This in turn will decrease readability a lot, IMHO. In addition, there are GPIOs that are set up by FSP and the configuration is done via devicetree. So there is no real, useable way in having all GPIOs described in in a single place anyway.
-
Werner Zeh (Code Review)