Hello Angel Pons, Jeremy Soller, Christian Walter,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37700
to review the following change.
Change subject: 3rdparty/fsp: Update to current master again ......................................................................
3rdparty/fsp: Update to current master again
We had to role the `fsp` submodule back for a minute due to a regression with the Coffee Lake binary. Intel silently mixed FSP 2.1 features into the Coffee Lake FSP which is supposed to be FSP 2.0. With the stack and heap usage partitioned for FSP using coreboot's stack (config FSP_USES_ CB_STACK), it works again.
To make this even messier: We already selected this Kconfig option for Whiskey Lake, which is supposed to use the very same FSP binary. So with either submodule pointer, something was always broken :-/
Change-Id: Id2aa17aaa2c843dcc7e0fb28779d1e5948da83c9 Signed-off-by: Nico Huber nico.huber@secunet.com --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/37700/1
diff --git a/3rdparty/fsp b/3rdparty/fsp index 9e53d77..0bc2b07 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 9e53d779eb34e944f9b3386ad6a9df80f710bddd +Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index c82660e..6d635ad 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -23,6 +23,7 @@ config SOC_INTEL_COFFEELAKE bool select SOC_INTEL_CANNONLAKE_BASE + select FSP_USES_CB_STACK help Intel Coffeelake support
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37700 )
Change subject: 3rdparty/fsp: Update to current master again ......................................................................
Patch Set 1: Code-Review+2
This looks good to me
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37700 )
Change subject: 3rdparty/fsp: Update to current master again ......................................................................
Patch Set 1: Code-Review+2
Maybe they spilled whiskey on this new FSP binary? ¯_(ツ)_/¯
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37700 )
Change subject: 3rdparty/fsp: Update to current master again ......................................................................
Patch Set 1:
Cool. Back to master again :)
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37700 )
Change subject: 3rdparty/fsp: Update to current master again ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37700 )
Change subject: 3rdparty/fsp: Update to current master again ......................................................................
3rdparty/fsp: Update to current master again
We had to role the `fsp` submodule back for a minute due to a regression with the Coffee Lake binary. Intel silently mixed FSP 2.1 features into the Coffee Lake FSP which is supposed to be FSP 2.0. With the stack and heap usage partitioned for FSP using coreboot's stack (config FSP_USES_ CB_STACK), it works again.
To make this even messier: We already selected this Kconfig option for Whiskey Lake, which is supposed to use the very same FSP binary. So with either submodule pointer, something was always broken :-/
Change-Id: Id2aa17aaa2c843dcc7e0fb28779d1e5948da83c9 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37700 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jeremy Soller jeremy@system76.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Mimoja coreboot@mimoja.de --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Mimoja: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Jeremy Soller: Looks good to me, approved
diff --git a/3rdparty/fsp b/3rdparty/fsp index 9e53d77..0bc2b07 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 9e53d779eb34e944f9b3386ad6a9df80f710bddd +Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index c82660e..6d635ad 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -23,6 +23,7 @@ config SOC_INTEL_COFFEELAKE bool select SOC_INTEL_CANNONLAKE_BASE + select FSP_USES_CB_STACK help Intel Coffeelake support
-
Angel Pons (Code Review) -
Jeremy Soller (Code Review)
-
Mimoja (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)