Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/71648
to review the following change.
Change subject: amdfwtool: Change "fall through" to "fallthrough" ......................................................................
amdfwtool: Change "fall through" to "fallthrough"
Fix the comment as "checkpatch" says.
Change-Id: Ifa5d7de037aa7024779f3aa4a5d2f5033eed264a Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 19 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/71648/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 4955f0b..301d69a 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -2458,13 +2458,13 @@ } } else { switch (efs_location) { - case 0: /* Fall through */ - case 0xFFFA0000: /* Fall through */ - case 0xFFF20000: /* Fall through */ - case 0xFFE20000: /* Fall through */ - case 0xFFC20000: /* Fall through */ - case 0xFF820000: /* Fall through */ - case 0xFF020000: /* Fall through */ + case 0: /* Fallthrough */ + case 0xFFFA0000: /* Fallthrough */ + case 0xFFF20000: /* Fallthrough */ + case 0xFFE20000: /* Fallthrough */ + case 0xFFC20000: /* Fallthrough */ + case 0xFF820000: /* Fallthrough */ + case 0xFF020000: /* Fallthrough */ break; default: fprintf(stderr, "Error: Invalid Directory location.\n");