Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45668 )
Change subject: soc/intel/common/../pmclib.h: Include <types.h> ......................................................................
soc/intel/common/../pmclib.h: Include <types.h>
This file uses `bool` and `size_t` types, so <stdint.h> isn't enough.
Change-Id: I8099142d92cc8ca6721f76522f3d30d4b6b9ee80 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/common/block/include/intelblocks/pmclib.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/45668/1
diff --git a/src/soc/intel/common/block/include/intelblocks/pmclib.h b/src/soc/intel/common/block/include/intelblocks/pmclib.h index 2123c4a..a339fb1 100644 --- a/src/soc/intel/common/block/include/intelblocks/pmclib.h +++ b/src/soc/intel/common/block/include/intelblocks/pmclib.h @@ -4,7 +4,7 @@ #define SOC_INTEL_COMMON_BLOCK_PMCLIB_H
#include <device/pci_type.h> -#include <stdint.h> +#include <types.h>
/* Forward declare the power state struct here */ struct chipset_power_state;
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45668 )
Change subject: soc/intel/common/../pmclib.h: Include <types.h> ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45668/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45668/1//COMMIT_MSG@7 PS1, Line 7: .. soc/intel/pmclib.h? 😉
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45668 )
Change subject: soc/intel/common/../pmclib.h: Include <types.h> ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45668/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45668/1//COMMIT_MSG@7 PS1, Line 7: ..
soc/intel/pmclib. […]
I prefer to indicate I've abbreviated something, while still providing enough information in the path prefix.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45668 )
Change subject: soc/intel/common/../pmclib.h: Include <types.h> ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45668/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45668/1//COMMIT_MSG@7 PS1, Line 7: ..
I prefer to indicate I've abbreviated something, while still providing enough information in the pat […]
Ack
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45668 )
Change subject: soc/intel/common/../pmclib.h: Include <types.h> ......................................................................
soc/intel/common/../pmclib.h: Include <types.h>
This file uses `bool` and `size_t` types, so <stdint.h> isn't enough.
Change-Id: I8099142d92cc8ca6721f76522f3d30d4b6b9ee80 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45668 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/common/block/include/intelblocks/pmclib.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/common/block/include/intelblocks/pmclib.h b/src/soc/intel/common/block/include/intelblocks/pmclib.h index 2123c4a..a339fb1 100644 --- a/src/soc/intel/common/block/include/intelblocks/pmclib.h +++ b/src/soc/intel/common/block/include/intelblocks/pmclib.h @@ -4,7 +4,7 @@ #define SOC_INTEL_COMMON_BLOCK_PMCLIB_H
#include <device/pci_type.h> -#include <stdint.h> +#include <types.h>
/* Forward declare the power state struct here */ struct chipset_power_state;