Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Daniel Peng has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87054?usp=email )
Change subject: mb/google/nissa/var/guren: Add WFC for AZWAVE/AM-3BA5533-B module
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS3:
Fix the suggestion and confirm the behavior was the same. Please help to review and submit if no concern. Thanks.
File src/mainboard/google/brya/variants/guren/variant.c:
https://review.coreboot.org/c/coreboot/+/87054/comment/8884d585_4224192f?usp... :
PS2, Line 24: config->usb2_ports[6].enable = 0;
: config->usb2_ports[6].ocpin = OC_SKIP;
: config->usb2_ports[6].tx_bias = USB2_BIAS_0MV;
: config->usb2_ports[6].tx_emp_enable = USB2_EMP_OFF;
: config->usb2_ports[6].pre_emp_bias = USB2_BIAS_0MV;
: config->usb2_ports[6].pre_emp_bit = USB2_HALF_BIT_PRE_EMP;
Can you try this? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87054?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia2ab019fe76c503cc669ebf4aa8b3d7ae72269c1
Gerrit-Change-Number: 87054
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 07 Apr 2025 02:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com