Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
acpi: Move ACPI table support out of arch/x86 (4/5)
This change moves all ACPI table support in coreboot currently living under arch/x86 into common code to make it architecture independent. ACPI table generation is not really tied to any architecture and hence it makes sense to move this to its own directory.
In order to make it easier to review, this change is being split into multiple CLs. This is change 4/5 which gets rid of the placeholder header files that were added to temporarily include acpi/ header files from arch/header files.
BUG=b:155428745
Change-Id: If6e8580c3c6433f9239e06a1dc7ba661b3f597e5 Signed-off-by: Furquan Shaikh furquan@google.com --- D src/arch/x86/include/arch/acpi.h D src/arch/x86/include/arch/acpi_device.h D src/arch/x86/include/arch/acpi_ivrs.h D src/arch/x86/include/arch/acpi_pld.h D src/arch/x86/include/arch/acpigen.h D src/arch/x86/include/arch/acpigen_dsm.h D src/arch/x86/include/arch/acpigen_ps2_keybd.h 7 files changed, 0 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40939/1
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h deleted file mode 100644 index 35cf6c6..0000000 --- a/src/arch/x86/include/arch/acpi.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi.h> diff --git a/src/arch/x86/include/arch/acpi_device.h b/src/arch/x86/include/arch/acpi_device.h deleted file mode 100644 index 5c3199e..0000000 --- a/src/arch/x86/include/arch/acpi_device.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi_device.h> diff --git a/src/arch/x86/include/arch/acpi_ivrs.h b/src/arch/x86/include/arch/acpi_ivrs.h deleted file mode 100644 index 032d253..0000000 --- a/src/arch/x86/include/arch/acpi_ivrs.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi_ivrs.h> diff --git a/src/arch/x86/include/arch/acpi_pld.h b/src/arch/x86/include/arch/acpi_pld.h deleted file mode 100644 index 5076e39..0000000 --- a/src/arch/x86/include/arch/acpi_pld.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi_pld.h> diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h deleted file mode 100644 index cdac49f..0000000 --- a/src/arch/x86/include/arch/acpigen.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpigen.h> diff --git a/src/arch/x86/include/arch/acpigen_dsm.h b/src/arch/x86/include/arch/acpigen_dsm.h deleted file mode 100644 index 0804ab9..0000000 --- a/src/arch/x86/include/arch/acpigen_dsm.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpigen_dsm.h> diff --git a/src/arch/x86/include/arch/acpigen_ps2_keybd.h b/src/arch/x86/include/arch/acpigen_ps2_keybd.h deleted file mode 100644 index 894524a..0000000 --- a/src/arch/x86/include/arch/acpigen_ps2_keybd.h +++ /dev/null @@ -1,7 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * SPDX-License-Identifier: GPL-2.0-or-later - */ - -#include <acpi/acpigen_ps2_keybd.h>
Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
acpi: Move ACPI table support out of arch/x86 (4/5)
This change moves all ACPI table support in coreboot currently living under arch/x86 into common code to make it architecture independent. ACPI table generation is not really tied to any architecture and hence it makes sense to move this to its own directory.
In order to make it easier to review, this change is being split into multiple CLs. This is change 4/5 which gets rid of the placeholder header files that were added to temporarily include acpi/ header files from arch/header files.
BUG=b:155428745
Change-Id: If6e8580c3c6433f9239e06a1dc7ba661b3f597e5 Signed-off-by: Furquan Shaikh furquan@google.com --- D src/arch/x86/include/arch/acpi.h D src/arch/x86/include/arch/acpi_device.h D src/arch/x86/include/arch/acpi_ivrs.h D src/arch/x86/include/arch/acpi_pld.h D src/arch/x86/include/arch/acpigen.h D src/arch/x86/include/arch/acpigen_dsm.h D src/arch/x86/include/arch/acpigen_ps2_keybd.h 7 files changed, 0 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40939/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
Patch Set 4: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
Patch Set 4: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
Patch Set 4: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
Patch Set 4: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
Patch Set 7: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40939 )
Change subject: acpi: Move ACPI table support out of arch/x86 (4/5) ......................................................................
acpi: Move ACPI table support out of arch/x86 (4/5)
This change moves all ACPI table support in coreboot currently living under arch/x86 into common code to make it architecture independent. ACPI table generation is not really tied to any architecture and hence it makes sense to move this to its own directory.
In order to make it easier to review, this change is being split into multiple CLs. This is change 4/5 which gets rid of the placeholder header files that were added to temporarily include acpi/ header files from arch/header files.
BUG=b:155428745
Change-Id: If6e8580c3c6433f9239e06a1dc7ba661b3f597e5 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40939 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- D src/arch/x86/include/arch/acpi.h D src/arch/x86/include/arch/acpi_device.h D src/arch/x86/include/arch/acpi_ivrs.h D src/arch/x86/include/arch/acpi_pld.h D src/arch/x86/include/arch/acpigen.h D src/arch/x86/include/arch/acpigen_dsm.h D src/arch/x86/include/arch/acpigen_ps2_keybd.h 7 files changed, 0 insertions(+), 31 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Aaron Durbin: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve Raul Rangel: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h deleted file mode 100644 index 35cf6c6..0000000 --- a/src/arch/x86/include/arch/acpi.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi.h> diff --git a/src/arch/x86/include/arch/acpi_device.h b/src/arch/x86/include/arch/acpi_device.h deleted file mode 100644 index 5c3199e..0000000 --- a/src/arch/x86/include/arch/acpi_device.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi_device.h> diff --git a/src/arch/x86/include/arch/acpi_ivrs.h b/src/arch/x86/include/arch/acpi_ivrs.h deleted file mode 100644 index 032d253..0000000 --- a/src/arch/x86/include/arch/acpi_ivrs.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi_ivrs.h> diff --git a/src/arch/x86/include/arch/acpi_pld.h b/src/arch/x86/include/arch/acpi_pld.h deleted file mode 100644 index 5076e39..0000000 --- a/src/arch/x86/include/arch/acpi_pld.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpi_pld.h> diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h deleted file mode 100644 index cdac49f..0000000 --- a/src/arch/x86/include/arch/acpigen.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpigen.h> diff --git a/src/arch/x86/include/arch/acpigen_dsm.h b/src/arch/x86/include/arch/acpigen_dsm.h deleted file mode 100644 index 0804ab9..0000000 --- a/src/arch/x86/include/arch/acpigen_dsm.h +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <acpi/acpigen_dsm.h> diff --git a/src/arch/x86/include/arch/acpigen_ps2_keybd.h b/src/arch/x86/include/arch/acpigen_ps2_keybd.h deleted file mode 100644 index 894524a..0000000 --- a/src/arch/x86/include/arch/acpigen_ps2_keybd.h +++ /dev/null @@ -1,7 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * SPDX-License-Identifier: GPL-2.0-or-later - */ - -#include <acpi/acpigen_ps2_keybd.h>
-
Aaron Durbin (Code Review) -
Duncan Laurie (Code Review)
-
Frans Hendriks (Code Review)
-
Furquan Shaikh (Code Review)
-
HAOUAS Elyes (Code Review)
-
Raul Rangel (Code Review)