Change in coreboot[master]: sc7280: shrm.elf loading changes - coreboot-gerrit

30 May 2021


      Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: shrm.elf loading changes
......................................................................
Patch Set 42:
(1 comment)
File src/soc/qualcomm/sc7280/shrm_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120299):
https://review.coreboot.org/c/coreboot/+/49392/comment/294ab8e2_ada17ca6 
PS42, Line 9: void shrm_fw_load_reset()
Bad function definition - void shrm_fw_load_reset() should probably be void shrm_fw_load_reset(void)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Gerrit-Change-Number: 49392
Gerrit-PatchSet: 42
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Sun, 30 May 2021 12:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment