Attention is currently required from: Arthur Heymans, Erik van den Bogaert, Felix Held, Paul Menzel, Shelley Chen.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82256?usp=email )
Change subject: soc/intel/braswell/Kconfig: Correct CONFIG_DCACHE_RAM_SIZE
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82256/comment/de900910_16114c0d :
PS2, Line 9: used'is
Please add a space.
Done
https://review.coreboot.org/c/coreboot/+/82256/comment/ec81f0da_5a69dd20 :
PS2, Line 13:
This reverts commit 156bc6f47a7c (soc/intel/braswell: Increase dcache size). […]
Added revert in comment.
FSP always use fixed 0x4000 AFAIK. The commit you refer, contains info that Braswell can be build, nothing around testing on real HW.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82256?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb781d5f0645a75cce0dc7a3808b2af3e3ce245a
Gerrit-Change-Number: 82256
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 08 May 2024 12:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment