HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37897 )
Change subject: mb/ibase/mb899: Remove unused includes ......................................................................
mb/ibase/mb899: Remove unused includes
Change-Id: I496da344cc0d3845c308bca4d5da46d9ca6f88a7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/ibase/mb899/acpi_tables.c M src/mainboard/ibase/mb899/early_init.c 2 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/37897/1
diff --git a/src/mainboard/ibase/mb899/acpi_tables.c b/src/mainboard/ibase/mb899/acpi_tables.c index f41b847..447b448 100644 --- a/src/mainboard/ibase/mb899/acpi_tables.c +++ b/src/mainboard/ibase/mb899/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <southbridge/intel/i82801gx/nvs.h>
void acpi_create_gnvs(global_nvs_t *gnvs) diff --git a/src/mainboard/ibase/mb899/early_init.c b/src/mainboard/ibase/mb899/early_init.c index fd96f66..7b5ff9a 100644 --- a/src/mainboard/ibase/mb899/early_init.c +++ b/src/mainboard/ibase/mb899/early_init.c @@ -14,9 +14,7 @@ */
#include <bootblock_common.h> -#include <stdint.h> #include <device/pnp_ops.h> -#include <cpu/x86/lapic.h> #include <device/pnp_def.h> #include <northbridge/intel/i945/i945.h> #include <southbridge/intel/i82801gx/i82801gx.h>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37897
to look at the new patch set (#2).
Change subject: mb/ibase/mb899: Remove unused includes ......................................................................
mb/ibase/mb899: Remove unused includes
Change-Id: I496da344cc0d3845c308bca4d5da46d9ca6f88a7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/ibase/mb899/acpi_tables.c M src/mainboard/ibase/mb899/early_init.c 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/37897/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37897 )
Change subject: mb/ibase/mb899: Remove unused includes ......................................................................
Patch Set 4:
This happened after rebasing on top of CB:37827 (src/include: Remove unused <stdlib.h>) instead of overloaded CB:32023 with the same purpose
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37897 )
Change subject: mb/ibase/mb899: Remove unused includes ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37897 )
Change subject: mb/ibase/mb899: Remove unused includes ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37897 )
Change subject: mb/ibase/mb899: Remove unused includes ......................................................................
mb/ibase/mb899: Remove unused includes
Change-Id: I496da344cc0d3845c308bca4d5da46d9ca6f88a7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37897 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/ibase/mb899/acpi_tables.c M src/mainboard/ibase/mb899/early_init.c 2 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/ibase/mb899/acpi_tables.c b/src/mainboard/ibase/mb899/acpi_tables.c index f41b847..447b448 100644 --- a/src/mainboard/ibase/mb899/acpi_tables.c +++ b/src/mainboard/ibase/mb899/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <southbridge/intel/i82801gx/nvs.h>
void acpi_create_gnvs(global_nvs_t *gnvs) diff --git a/src/mainboard/ibase/mb899/early_init.c b/src/mainboard/ibase/mb899/early_init.c index fd96f66..838d3a3 100644 --- a/src/mainboard/ibase/mb899/early_init.c +++ b/src/mainboard/ibase/mb899/early_init.c @@ -14,16 +14,13 @@ */
#include <bootblock_common.h> -#include <stdint.h> #include <device/pnp_ops.h> -#include <cpu/x86/lapic.h> #include <device/pnp_def.h> #include <northbridge/intel/i945/i945.h> #include <southbridge/intel/i82801gx/i82801gx.h> #include <superio/winbond/common/winbond.h> #include <superio/winbond/w83627ehg/w83627ehg.h>
-#define SERIAL_DEV PNP_DEV(0x4e, W83627EHG_SP1) #define SUPERIO_DEV PNP_DEV(0x4e, 0)
/* This box has one superio