Attention is currently required from: Bora Guvendik, Jeremy Compostella, Wonkyu Kim.
Julius Werner has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/87032?usp=email )
Change subject: vc/google/chromeos: Add TPM_GOOGLE config check for logo selection ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87032/comment/1c4c6c6c_218b0d2e?usp... : PS1, Line 10: configuration within the bmp_logo_filename function. The most important part of a commit message is to explain *why* you're doing something, not just what you're doing (which is obvious from the code in this case). Why are you doing this?
If you just want to make this run on devices without GSC then you should probably do that inside `chromeos_get_factory_config()` instead, e.g. just return the uninitialized value if that Kconfig isn't set.