Hello Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31347
to review the following change.
Change subject: libpayload/storage: Add Apollo Lake AHCI ID ......................................................................
libpayload/storage: Add Apollo Lake AHCI ID
Change-Id: Iee244d0cd7d64934fbfc34778a45e21e97646628 Signed-off-by: Nico Huber nico.huber@secunet.com --- M payloads/libpayload/drivers/storage/ahci.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/31347/1
diff --git a/payloads/libpayload/drivers/storage/ahci.c b/payloads/libpayload/drivers/storage/ahci.c index bb0d37e..6cc3866 100644 --- a/payloads/libpayload/drivers/storage/ahci.c +++ b/payloads/libpayload/drivers/storage/ahci.c @@ -224,6 +224,7 @@ 0x8086 | 0x1c03 << 16, /* Mobile Cougar Point PCH */ 0x8086 | 0x1e03 << 16, /* Mobile Panther Point PCH */ 0x8086 | 0xa102 << 16, /* Desktop / Mobile-Wks Sunrise Point PCH */ + 0x8086 | 0x5ae3 << 16, /* Apollo Lake */ }; #endif static void ahci_init_pci(pcidev_t dev)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31347 )
Change subject: libpayload/storage: Add Apollo Lake AHCI ID ......................................................................
Patch Set 1: Code-Review+1
… to tested controllers.
Hello Julius Werner, Angel Pons, Paul Menzel, Stefan Reinauer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31347
to look at the new patch set (#2).
Change subject: libpayload/storage: Add Apollo Lake AHCI ID to tested controllers ......................................................................
libpayload/storage: Add Apollo Lake AHCI ID to tested controllers
Change-Id: Iee244d0cd7d64934fbfc34778a45e21e97646628 Signed-off-by: Nico Huber nico.huber@secunet.com --- M payloads/libpayload/drivers/storage/ahci.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/31347/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31347 )
Change subject: libpayload/storage: Add Apollo Lake AHCI ID to tested controllers ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31347 )
Change subject: libpayload/storage: Add Apollo Lake AHCI ID to tested controllers ......................................................................
libpayload/storage: Add Apollo Lake AHCI ID to tested controllers
Change-Id: Iee244d0cd7d64934fbfc34778a45e21e97646628 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31347 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M payloads/libpayload/drivers/storage/ahci.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/payloads/libpayload/drivers/storage/ahci.c b/payloads/libpayload/drivers/storage/ahci.c index fbfcf97..40e1008 100644 --- a/payloads/libpayload/drivers/storage/ahci.c +++ b/payloads/libpayload/drivers/storage/ahci.c @@ -224,6 +224,7 @@ 0x8086 | 0x1c03 << 16, /* Mobile Cougar Point PCH */ 0x8086 | 0x1e03 << 16, /* Mobile Panther Point PCH */ 0x8086 | 0xa102 << 16, /* Desktop / Mobile-Wks Sunrise Point PCH */ + 0x8086 | 0x5ae3 << 16, /* Apollo Lake */ }; #endif static void ahci_init_pci(pcidev_t dev)
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)
-
Thomas Heijligen (Code Review)