Change in coreboot[master]: payloads/nvramcui: Select USE_OPTION_TABLE

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40222 )

Change subject: payloads/nvramcui: Select USE_OPTION_TABLE
......................................................................

payloads/nvramcui: Select USE_OPTION_TABLE

nvramcui requires use of CMOS for NVRAM configuration,
so depend on HAVE_OPTION_TABLE and select USE_OPTION_TABLE
to ensure that nvramcui is actually functional when included
in a build.

Change-Id: I0595514f636b8ce67bbc789ecc96a93c99068c50
Signed-off-by: Matt DeVillier 
---
M payloads/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/40222/1

diff --git a/payloads/Kconfig b/payloads/Kconfig
index f85dce9..cfb28d6 100644
--- a/payloads/Kconfig
+++ b/payloads/Kconfig
@@ -132,7 +132,8 @@
 config NVRAMCUI_SECONDARY_PAYLOAD
    bool "Load nvramcui as a secondary payload"
    default n
-	depends on ARCH_X86
+	depends on ARCH_X86 && HAVE_OPTION_TABLE
+	select USE_OPTION_TABLE
    help
      nvramcui can be loaded as a secondary payload under SeaBIOS, GRUB,
      or any other payload that can load additional payloads.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40222 )

Change subject: payloads/nvramcui: Select USE_OPTION_TABLE
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40222 )

Change subject: payloads/nvramcui: Select USE_OPTION_TABLE
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40222 )

Change subject: payloads/nvramcui: Select USE_OPTION_TABLE
......................................................................

payloads/nvramcui: Select USE_OPTION_TABLE

nvramcui requires use of CMOS for NVRAM configuration,
so depend on HAVE_OPTION_TABLE and select USE_OPTION_TABLE
to ensure that nvramcui is actually functional when included
in a build.

Change-Id: I0595514f636b8ce67bbc789ecc96a93c99068c50
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40222
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
---
M payloads/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/payloads/Kconfig b/payloads/Kconfig
index f85dce9..cfb28d6 100644
--- a/payloads/Kconfig
+++ b/payloads/Kconfig
@@ -132,7 +132,8 @@
 config NVRAMCUI_SECONDARY_PAYLOAD
    bool "Load nvramcui as a secondary payload"
    default n
-	depends on ARCH_X86
+	depends on ARCH_X86 && HAVE_OPTION_TABLE
+	select USE_OPTION_TABLE
    help
      nvramcui can be loaded as a secondary payload under SeaBIOS, GRUB,
      or any other payload that can load additional payloads.

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40222 )

Change subject: payloads/nvramcui: Select USE_OPTION_TABLE
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2210
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2209
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2208

Please note: This test is under development and might not be accurate at all!