Attention is currently required from: Maulik V Vaghela, Christian Walter, Angel Pons, Lean Sheng Tan.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61528 )
Change subject: mb/intel/adlrvp: Fix vbt loading error
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I agree
The fallback path is still "vbt.bin" ? Do we have issue.
return "vbt.bin";
I guess the issue here is based on DDR5 board id, we are expecting to stitch a vbt_adlrvp_ddr5.bin instead vbt.bin
case ADL_P_DDR5_1:
case ADL_P_DDR5_2:
return "vbt_adlrvp_ddr5.bin";
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f6f9554b75f4d62198aac9938e65c71c3e7cee9
Gerrit-Change-Number: 61528
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 02 Feb 2022 07:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment