Ravishankar Sarawadi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
soc/intel/tigerlake: Fix PMC config
Fix PMC base address for tigerlake.
BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: Id13222eb5498a5704c11d6b4d1e83212bd8b2723 --- M src/soc/intel/tigerlake/bootblock/pch.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/37784/1
diff --git a/src/soc/intel/tigerlake/bootblock/pch.c b/src/soc/intel/tigerlake/bootblock/pch.c index 1ef4928..62c6dd1 100644 --- a/src/soc/intel/tigerlake/bootblock/pch.c +++ b/src/soc/intel/tigerlake/bootblock/pch.c @@ -37,7 +37,7 @@ #include <soc/pcr_ids.h> #include <soc/pm.h>
-#define PCR_PSF3_TO_SHDW_PMC_REG_BASE 0x0600 +#define PCR_PSF3_TO_SHDW_PMC_REG_BASE 0x1100 #define PCR_PSFX_TO_SHDW_BAR0 0 #define PCR_PSFX_TO_SHDW_BAR1 0x4 #define PCR_PSFX_TO_SHDW_BAR2 0x8
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
Patch Set 2: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
Patch Set 2: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
Patch Set 2: Code-Review+2
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37784 )
Change subject: soc/intel/tigerlake: Fix PMC config ......................................................................
soc/intel/tigerlake: Fix PMC config
Fix PMC base address for tigerlake.
BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: Id13222eb5498a5704c11d6b4d1e83212bd8b2723 Reviewed-on: https://review.coreboot.org/c/coreboot/+/37784 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Shaunak Saha shaunak.saha@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/tigerlake/bootblock/pch.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Shaunak Saha: Looks good to me, approved Subrata Banik: Looks good to me, approved Nick Vaccaro: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/bootblock/pch.c b/src/soc/intel/tigerlake/bootblock/pch.c index 7a93182..1654809 100644 --- a/src/soc/intel/tigerlake/bootblock/pch.c +++ b/src/soc/intel/tigerlake/bootblock/pch.c @@ -40,7 +40,7 @@ #include <soc/pcr_ids.h> #include <soc/pm.h>
-#define PCR_PSF3_TO_SHDW_PMC_REG_BASE_TGP 0x0600 +#define PCR_PSF3_TO_SHDW_PMC_REG_BASE_TGP 0x1100 #define PCR_PSF3_TO_SHDW_PMC_REG_BASE_JSP 0x0980 #define PCR_PSFX_TO_SHDW_BAR0 0 #define PCR_PSFX_TO_SHDW_BAR1 0x4
-
Nick Vaccaro (Code Review) -
Ravishankar Sarawadi (Code Review)
-
Shaunak Saha (Code Review)
-
Subrata Banik (Code Review)
-
Wonkyu Kim (Code Review)