Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60599 )
Change subject: pci_device.c: Don't guard `pci_dev_disable_bus_master()` ......................................................................
pci_device.c: Don't guard `pci_dev_disable_bus_master()`
The `pci_dev_disable_bus_master()` function doesn't need to be guarded with `CONFIG(PC80_SYSTEM)`, so move it out of the guard.
Change-Id: I813e0f72c3c624c73ab9ecbe7512359608ace927 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/60599 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Felix Singer: Looks good to me, approved
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 1075ef7..a61fbd6 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1472,6 +1472,11 @@ pci_scan_bus(link, PCI_DEVFN(0, 0), 0xff); }
+void pci_dev_disable_bus_master(const struct device *dev) +{ + pci_update_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER, 0x0); +} + /** * Take an INT_PIN number (0, 1 - 4) and convert * it to a string ("NO PIN", "PIN A" - "PIN D") @@ -1665,9 +1670,4 @@ i8259_configure_irq_trigger(irq, IRQ_LEVEL_TRIGGERED); } } - -void pci_dev_disable_bus_master(const struct device *dev) -{ - pci_update_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER, 0x0); -} #endif