Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64126 )
Change subject: soc/amd/cezanne/fsp_m_params: add defines for FSP USB struct version ......................................................................
soc/amd/cezanne/fsp_m_params: add defines for FSP USB struct version
Add and use defines instead of magic values in fsp_m_params.c.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ie0e33eb0af5310ab4610ea8951688464c4960260 --- M src/soc/amd/cezanne/fsp_m_params.c M src/vendorcode/amd/fsp/cezanne/FspUsb.h 2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/64126/1
diff --git a/src/soc/amd/cezanne/fsp_m_params.c b/src/soc/amd/cezanne/fsp_m_params.c index 0c423ea..7105cfb 100644 --- a/src/soc/amd/cezanne/fsp_m_params.c +++ b/src/soc/amd/cezanne/fsp_m_params.c @@ -150,8 +150,8 @@
if (config->usb_phy_custom) { mcfg->usb_phy = (struct usb_phy_config *)&config->usb_phy; - mcfg->usb_phy->Version_Major = 0xd; - mcfg->usb_phy->Version_Minor = 0x6; + mcfg->usb_phy->Version_Major = FSP_USB_STRUCT_MAJOR_VERSION; + mcfg->usb_phy->Version_Minor = FSP_USB_STRUCT_MINOR_VERSION; mcfg->usb_phy->TableLength = sizeof(usb_phy_config); } else { mcfg->usb_phy = NULL; diff --git a/src/vendorcode/amd/fsp/cezanne/FspUsb.h b/src/vendorcode/amd/fsp/cezanne/FspUsb.h index 6563cac..fea1fee 100644 --- a/src/vendorcode/amd/fsp/cezanne/FspUsb.h +++ b/src/vendorcode/amd/fsp/cezanne/FspUsb.h @@ -3,6 +3,9 @@
#include <FspUpd.h>
+#define FSP_USB_STRUCT_MAJOR_VERSION 0xd +#define FSP_USB_STRUCT_MINOR_VERSION 0x6 + #define USB2_PORT_COUNT 8 #define USB3_PORT_COUNT 4 #define USBC_COMBO_PHY_COUNT 2