Attention is currently required from: Felix Held, Nico Huber.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81296?usp=email )
Change subject: Docs/tutorial: Do not install Ada compiler by default ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i wonder why the ada compiler is causing issues for some user; always worked for me. […]
Thanks for your review. Two points - 1/2) There were linking issues when building crossgcc-i386. Symbols like "__gnat_raise_from_signal_handler" were missing. This symbol is just one example. There were other symbols missing as well. Looked at multiple ways to resolve this: https://mail.coreboot.org/hyperkitty/list/coreboot-gerrit@coreboot.org/messa... Some forums suggested that this issue usually crops up when the versions of gcc and Ada mismatch. For people who want to try coreboot, having to downgrade or upgrade their existing gcc to make sure the versions for both gcc and Ada match might be a roadblock and/or deal breaker.
2/2) Tutorial seems to suggest that only bare minimum necessary to get a newbie to quickly start with coreboot on QEMU was described. However, requiring Ada compiler install, resulting in breaking the coreboot toolchain build process, seems to be an unnecessary hassle for a newbie to deal with. A newbie could always install Ada compiler when they really need it. For example, I, a newbie, did not need Ada compiler in order to boot the coreboot I built using QEMU.
BTW, that's why I made this point in my commit: "The warning printed by have_gnat() in util/crossgcc/buildgcc might still be useful." So, experienced users could still stop the build, install Ada compiler if they'd like to, then go back to installing the toolchain. I just have an issue with forcing newbies to install stuff they don't immediately need. Once they see the value of installing something extra, they could always do that then.
-
Naveen Iyer (Code Review)