Attention is currently required from: Felix Held, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78220?usp=email )
Change subject: soc/amd/genoa: Add GPIO definitions
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/genoa/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/78220/comment/e4fd5285_98d2295f :
PS4, Line 108: #define GPIO_0_IOMUX_GPIO_PU1PD0 1
: #define GPIO_0_IOMUX_GPIO 2
the mux setting to be used for gpio for this pin needs to be GPIO_0_IOMUX_GPIOxx to match the define […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78220?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c4e425699c9a158ca95a1baf94f7756f0b12b44
Gerrit-Change-Number: 78220
Gerrit-PatchSet: 5
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 09 Oct 2023 13:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment