Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad hold time to 400ns ......................................................................
mb/google/hatch/akemi: Set touchpad hold time to 400ns
According to SI team request, need to tune I2C bus 0 data hold time more than 300ns
BUG=None TEST=build firmware and measure I2C bus 0 data hold time
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I75e33419cbaef746487de6ee8628d07cf08adaa9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/37322/1
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index da669e4..937810b 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -57,6 +57,7 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 50, .fall_time_ns = 15, + .data_hold_time_ns = 400, }, .i2c[1] = { .speed = I2C_SPEED_FAST,
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37322
to look at the new patch set (#2).
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
mb/google/hatch/akemi: Set touchpad data hold time more than 300ns
According to SI team and vendor request, need to tune I2C bus 0 data hold time more than 300ns
BUG=b:146163044 TEST=build firmware and measure I2C bus 0 data hold time
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I75e33419cbaef746487de6ee8628d07cf08adaa9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/37322/2
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400 Didn't you say 300? 33% of headroom seems a lot.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
Didn't you say 300? […]
Dear Philip, I have update vendor EMC's requirement to issue tracker. Please kindly check. He said the data hold time need more than 0.3 micro second. Thanks a lot!
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
Dear Philip, I have update vendor EMC's requirement to issue tracker. Please kindly check. […]
We're just curious why 400 and not 310 or 325 or something like that then?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
We're just curious why 400 and not 310 or 325 or something like that then?
Dear Tim,
Sure, this signal measure result more than 0.3ms, so meet vendor requirement.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
Dear Tim, […]
Does 310 or 325 not meet vendor requirement?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
Does 310 or 325 not meet vendor requirement?
No, 310 or 325 also meet requirement, vendor requirement 0.3us <= x <= 0.9us. If use default, real measure result rough equal 0.29us. So do this modification.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
No, 310 or 325 also meet requirement, vendor requirement 0.3us <= x <= 0.9us. […]
400ns seems really high, but if it works for you then I guess it's okay.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37322/2/src/mainboard/google/hatch/... PS2, Line 60: 400
400ns seems really high, but if it works for you then I guess it's okay.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37322 )
Change subject: mb/google/hatch/akemi: Set touchpad data hold time more than 300ns ......................................................................
mb/google/hatch/akemi: Set touchpad data hold time more than 300ns
According to SI team and vendor request, need to tune I2C bus 0 data hold time more than 300ns
BUG=b:146163044 TEST=build firmware and measure I2C bus 0 data hold time
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I75e33419cbaef746487de6ee8628d07cf08adaa9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/37322 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Philip Chen philipchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Philip Chen: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 9b0f5f7..d236cb0 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -57,6 +57,7 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 50, .fall_time_ns = 15, + .data_hold_time_ns = 400, }, .i2c[1] = { .speed = I2C_SPEED_FAST,
-
Patrick Georgi (Code Review) -
Peichao Li (Code Review)
-
Philip Chen (Code Review)
-
Tim Wawrzynczak (Code Review)