Attention is currently required from: Martin L Roth, Nicholas Chin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 )
Change subject: Documentation/contributing: Add Sign-off procedure ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74825/comment/65f41ff3_44d4828d PS1, Line 14: sign : off In the summary/title you spelled it Sign-off.
https://review.coreboot.org/c/coreboot/+/74825/comment/1540efad_8df42d65 PS1, Line 14: In addition, the Linux kernel recently updated the wording of their sign : off procedure, changing the ambiguous "real name" requirement to "a : known identity" and dropping "no pseudonyms". Anonymous contributions : remain uncommittable [1]. As discussed in the April 19, 2023 leadership : meeting, update our policy to go along with Linux and flashrom (who also : updated their policy). I’d make that a separate commit.
File Documentation/contributing/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/74825/comment/e498867d_08335806 PS1, Line 142: pushed to gerrit, and will be rejected by coreboot's CI system. Remove the trailing space?
https://review.coreboot.org/c/coreboot/+/74825/comment/3d097797_bada9f9c PS1, Line 148: [SCO-Linux disputes] for the rationale behind the DCO. Remove the trailing space?
https://review.coreboot.org/c/coreboot/+/74825/comment/b4e8d861_5f88dcd5 PS1, Line 151: ```text : By making a contribution to this project, I certify that: : : (a) The contribution was created in whole or in part by me and I have : the right to submit it under the open source license indicated in the : file; or : : (b) The contribution is based upon previous work that, to the best of my : knowledge, is covered under an appropriate open source license and I : have the right under that license to submit that work with : modifications, whether created in whole or in part by me, under the same : open source license (unless I am permitted to submit under a different : license), as indicated in the file; or : : (c) The contribution was provided directly to me by some other person : who certified (a), (b) or (c) and I have not modified it; and : : (d) In the case of each of (a), (b), or (c), I understand and agree that : this project and the contribution are public and that a record of the : contribution (including all personal information I submit with it, : including my sign-off) is maintained indefinitely and may be : redistributed consistent with this project or the open source license : indicated in the file. : ``` I’d mark this up as a citation?
-
Paul Menzel (Code Review)