Attention is currently required from: Derek Huang, Karthik Ramasubramanian.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email )
Change subject: mb/google/dedede/var/galtic: Re-factor the Memory Setting
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79976/comment/48efefad_1c9dae3f :
PS2, Line 7: Re-factor the Memory Setting
It looks to me that the CL correct the memory part which was used. […]
The original memory `K4UBE3D4AA-MGCR` is used to spd-3.hex in mem_parts_used.txt, not for the spd-1.hex.
Actually we used `K4U6E3S4AA-MGCR` in Gal* serial project which is used for spd-1.hex.
Or what your means is that I should change the description of Title?
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79976?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41
Gerrit-Change-Number: 79976
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 15 Jan 2024 07:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Gerrit-MessageType: comment