Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50515 )
Change subject: soc/amd/picasso/psp: move to common code and rename to psp_smm_gen2
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I think I've expressed reservations elsewhere about moving SMIxnnn registers to common, i.e. someday we may find they're not as common as we expected so additional work will be required. For this patch we're using a couple of named registers in that space (OK) but also bit definitions at the top of SMITRG0. However, those have seemed to stay unchanged across products.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I771a7d36eea7307754386824190624a09c0e38f7
Gerrit-Change-Number: 50515
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 15:47:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment