Attention is currently required from: Tarun Tuli, Michał Żygowski, Subrata Banik, Paul Menzel, Michał Kopeć.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68945 )
Change subject: soc/intel/alderlake: Hook up the OC watchdog
......................................................................
Patch Set 15:
(1 comment)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/68945/comment/332945dd_2e8fef55
PS15, Line 137: is_wdt_enabled();
This looks strange.
I guess your intention is to see the current OC_WDT status in the log. If so, then move the printk() to this place and let the is_wdt_enabled() function be silent. Otherwise I would rename this function to 'show_oc_wdt_status' or the like.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c2c640d48b7e03ad8cd8d6cdf6aac447e93cd86
Gerrit-Change-Number: 68945
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Fri, 03 Mar 2023 09:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment