Attention is currently required from: Furquan Shaikh, Ivy Jian, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52602 )
Change subject: mb/google/mancomb: Enable VBOOT_LID_SWITCH
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52602/comment/f8d56851_9469760a
PS1, Line 13: TEST=Depthcharge no longer halts complaining that coreboot didn't sample
: the pin
Thanks for suggestion,I just tried on depthcharge change, but still halt in depthcarge. […]
Need to remove it from here too: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52602
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd0fcec9557bf7ebad64ce9342d3b50eb511522b
Gerrit-Change-Number: 52602
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment