Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Stefan Reinauer, Morgan Jang, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52446 )
Change subject: soc/intel/xeon_sp/cpx: Add IMC locks
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/52446/comment/a4b9c3d6_01c9756b
PS1, Line 176: pci_or_config32(pcidev_path_on_root(PCI_DEVFN(0, 0)), 0x80, 1 << 0);
Unknown. I don't see this in the docs and the register isn't set runtime. […]
Oh, I just saw CB:51532
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5c43711e80f4e2112c305a9b48d0a4c8509e89b
Gerrit-Change-Number: 52446
Gerrit-PatchSet: 3
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 22 Apr 2021 10:48:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment