[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)

[Paul Menzel (Code Review)]

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh, Jan Samek.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 )

Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
......................................................................

Patch Set 13:

(2 comments)

File src/drivers/i2c/pi608gp/pi608gp.c:

https://review.coreboot.org/c/coreboot/+/74433/comment/6160f8ae_4dcba32e 
PS12, Line 48: {  0, 0}
> I would like to keep the numbers aligned, as it reads better and can be easier compared with the tab […]

Oh, now I noticed it. It is probably one of the cases, where automatic formatting tools are also going to trip. But coreboot does not use those yet, so I am marking this as resolved.

https://review.coreboot.org/c/coreboot/+/74433/comment/b1813b7f_c11bc6cb 
PS12, Line 71: /* Compose the SMBus message for register read init operation (from MSB to LSB):
             : 	   Byte 1: 7:3 = Rsvd., 2:0 = Command,
             : 	   Byte 2: 7:4 = Rsvd., 3:0 = Port Select[4:1],
             : 	   Byte 3: 7 = Port Select[0], 6 = Rsvd., 5:2 = Byte Enable, 1:0 = Reg. Addr. [11:10],
             : 	   Byte 4: 7:0 = Reg. Addr.[9:2] (Reg. Addr. [1:0] fixed to 0). */
> Can you please elaborate, e.g. […]

I’d use:

/*
     * Compose …
     * […]
     */