Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: mainboard/lenovo/t410: Add new port ......................................................................
Patch Set 23:
(3 comments)
https://review.coreboot.org/c/coreboot/+/11791/23/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/11791/23/src/mainboard/lenovo/t410/... PS23, Line 120: remove tab and fix alignment of things below.
https://review.coreboot.org/c/coreboot/+/11791/23/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/c/coreboot/+/11791/23/src/mainboard/lenovo/t410/... PS23, Line 28: : /* Seems copied from Lenovo Thinkpad x201, might be wrong */ fix?
https://review.coreboot.org/c/coreboot/+/11791/23/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/smihandler.c:
https://review.coreboot.org/c/coreboot/+/11791/23/src/mainboard/lenovo/t410/... PS23, Line 32: mainboard_io_trap_handler There are no ACPI calls for IO trap, so please rename this and reduce the scope.
I have a local version fixing this on x201...
-
Arthur Heymans (Code Review)