Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44587 )
Change subject: mb/google/dedede: Add support for variant specific SMI sleep flow ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44587/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:
https://review.coreboot.org/c/coreboot/+/44587/6/src/mainboard/google/dedede... PS6, Line 49: /* Leave for the variant to implement if necessary. */
I think the name has you covered already 😊
Ack
https://review.coreboot.org/c/coreboot/+/44587/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/44587/6/src/mainboard/google/dedede... PS6, Line 39: smi
SMI
Done