Attention is currently required from: Tim Wawrzynczak, Shou-Chieh Hsu, Leo Chou.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68075 )
Change subject: mb/google/nissa/var/pujjo: Disable stylus GPIO pins based on fw_config
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68075/comment/8da08c6a_d72bfc19
PS1, Line 7: mb/google/nissa/var/pujjo: Disable stylus GPIO pins based on
: fw_config
nit: please combine these into one line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4218748cb06426a918d89f688599c652062ac78c
Gerrit-Change-Number: 68075
Gerrit-PatchSet: 1
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Jynn Chen
jynn.chen@lcfc.corp-partner.google.com
Gerrit-CC: Leanne1 Chen
leanne1.chen@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 00:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment