Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39425/22/src/soc/intel/xeon_sp/incl...
File src/soc/intel/xeon_sp/include/soc/lewisburg_pch_gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/39425/22/src/soc/intel/xeon_sp/incl...
PS22, Line 665: #define GPI_SMI_STS_0 0x180
: #define GPI_SMI_EN_0 0x1a0
well, aren't these wrong? the datasheet you mentioned tells me 0x140, 0x150
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idde32fdd53f1966e3ba6b7f5598ae8f51488d5a5
Gerrit-Change-Number: 39425
Gerrit-PatchSet: 22
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 19:36:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment