Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter. Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Accept Google Ti50 TPM DID:VID ......................................................................
Patch Set 11:
(3 comments)
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/8c7a8a4a_245e57b6 PS11, Line 422: H1D3 nit: H1D3C
File src/drivers/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/8fc1aeb0_c5b1828e PS11, Line 109: if (!CONFIG(TPM_CR50)) : return 0; let's add a comment to why we are skipping here (e.g. // if we get here and we aren't cr50, then we must be ti50 which does not currentlt need to support board_cfg register read)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/63158/comment/408d3b75_376f1565 PS11, Line 58: BOARD_GOOGLE_BASEBOARD_NISSA shouldn't we add `MAINBOARD_HAS_I2C_TPM_TI50` to this list if we are removing the workaround?
-
Jett Rink (Code Review)