Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph, Jeremy Soller, Tim Wawrzynczak, Christian Walter.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60203 )
Change subject: mainboard: Fix DPTF device state in the devicetree on CFL boards
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60203/comment/f53803e1_41b5b0c6
PS2, Line 12: * google/hatch
As Tim wrote, he tested google/dratini. […]
Done
Wording could be better though, currently it suggests all of hatch is affected.
https://review.coreboot.org/c/coreboot/+/60203/comment/92c6e6ff_3e2859bb
PS2, Line 14: Thus, set it to on to make the resource allocator aware of it.
Anything to do here?
Worth to mention in the commit message, IMHO. Or just rephrase. Currently
it suggests to me that the resource allocation is the only difference. While
it's just one of many side effects.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I561598c252c5da64ece569c6ba336852e713ccab
Gerrit-Change-Number: 60203
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Wed, 22 Dec 2021 12:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment