Change in coreboot[master]: mb/google/volteer: Reset the M.2 bluetooth module on system reset

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Shaunak Saha (Code Review)

26 Oct 2020 26 Oct '20

8:29 p.m.

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: Reset the M.2 bluetooth module on system reset ......................................................................

mb/google/volteer: Reset the M.2 bluetooth module on system reset

This patch helps to reset bluetooth by toggling BT_DISABLE_L by reseting the GPIO pin A13.

BUG=b:171085081 TEST=Build and boot a delbin device. Test that the BT is getting reset by toggling the gpio pin A13 through iotools in kernel console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/1

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 69f58b5..2183322 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -22,6 +22,7 @@ select FW_CONFIG_SOURCE_CHROMEEC_CBI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select DRIVERS_USB_ACPI select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_SPI_TPM_CR50 diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 2a62505..37000c1 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -431,7 +431,17 @@ device ref gna on end device ref north_xhci on end device ref cnvi_bt on end - device ref south_xhci on end + device ref south_xhci on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Integrated CnVi bluetooth"" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" + device usb 2.9 on end + end + end + end + end device ref shared_ram on end chip drivers/wifi/generic register "wake" = "GPE0_PME_B0"

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Shaunak Saha (Code Review)

26 Oct 26 Oct

8:32 p.m.

Shaunak Saha has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: Reset the M.2 bluetooth module on system reset ......................................................................

mb/google/volteer: Reset the M.2 bluetooth module on system reset

This patch helps to reset bluetooth by toggling BT_DISABLE_L by reseting the GPIO pin A13.

BUG=b:171085081 TEST=Build and boot a delbin device. Test that the BT is getting reset by toggling the gpio pin A13 through iotools in kernel console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/2

Shaunak Saha (Code Review)

8:38 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46825

to look at the new patch set (#3).

Change subject: mb/google/volteer: Reset the M.2 bluetooth module on system reset ......................................................................

mb/google/volteer: Reset the M.2 bluetooth module on system reset

This patch helps to reset bluetooth by toggling BT_DISABLE_L by reseting the GPIO pin A13.

BUG=b:171085081 TEST=Build and boot a delbin device. Test that the BT is getting reset by toggling the gpio pin A13 through iotools in kernel console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/3

Tim Wawrzynczak (Code Review)

10:22 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: Reset the M.2 bluetooth module on system reset ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG@7 PS3, Line 7: Reset the M.2 bluetooth module on system reset This patch doesn't really do the reset, it just passes the reset GPIO to the OS.

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG@9 PS3, Line 9: reseting resetting

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG@13 PS3, Line 13: Test that the BT is getting reset : by toggling the gpio pin A13 through iotools in kernel console. This doesn't really test that we are exposing the GPIO through ACPI.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 3 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 26 Oct 2020 21:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sukumar Ghorai (Code Review)

11:51 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Sukumar Ghorai has uploaded a new patch set (#4) to the change originally created by Shaunak Saha. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Platform GPIO pin A13 connected to Bluetooth(bt) W_DISABLE2# pin. And coreboot exposed an gpio-reset for bt-usb driver to use to reset the Intel BT Chip, where the firmware gets stuck and the only way out is a hard reset pin provided by the platform.

BUG=b:171085081 TEST= Verify kernel log "usb 3-10: GPIO lookup for consumer reset"

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 4 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Sukumar Ghorai (Code Review)

11:51 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Sukumar Ghorai has uploaded a new patch set (#5) to the change originally created by Shaunak Saha. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

mb/google/volteer: provide gpio-reset interface for Bluetooth reset

BUG=b:171085081 TEST= Verify kernel log "usb 3-10: GPIO lookup for consumer reset"

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 5 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Sukumar Ghorai (Code Review)

11:53 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 5: Code-Review+1

Verified; using kernel hack (mimic the bt-command timeout) to invoke the bt-reset.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 5 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 26 Oct 2020 22:53:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sukumar Ghorai (Code Review)

11:53 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG@7 PS3, Line 7: Reset the M.2 bluetooth module on system reset

...

This patch doesn't really do the reset, it just passes the reset GPIO to the OS.

Ack

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG@9 PS3, Line 9: reseting

...

resetting

Ack

https://review.coreboot.org/c/coreboot/+/46825/3//COMMIT_MSG@13 PS3, Line 13: Test that the BT is getting reset : by toggling the gpio pin A13 through iotools in kernel console.

...

This doesn't really test that we are exposing the GPIO through ACPI.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 5 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 26 Oct 2020 22:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Shaunak Saha (Code Review)

27 Oct 27 Oct

12:19 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Hello build bot (Jenkins), Caveh Jalali, Nick Vaccaro, Tim Wawrzynczak, Sukumar Ghorai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46825

to look at the new patch set (#6).

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Platform GPIO pin A13 is connected to Bluetooth(bt) W_DISABLE2# pin. With this patch coreboot is exposing a gpio-reset for bt-usb driver as an ACPI method in SSDT which can be used to reset the Intel BT Chip in case firmware gets stuck and the only way out is a hard reset pin provided by the platform.

BUG=b:171085081 TEST= Verify kernel log "usb 3-10: GPIO lookup for consumer reset"

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

1:11 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 6: Code-Review+2

Currently all of the variants do have this on A13, but it's something to keep an eye out for in any future variants (because it's in the baseboard devtree).

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 00:11:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

4:51 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 6: Code-Review-1

The usb config is per-variant, this needs to go in overridetree. I have some patches coming to define all the usb ports.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 15:51:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:32 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 6: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 16:32:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sukumar Ghorai (Code Review)

5:44 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 6:

...

Patch Set 6: Code-Review-1

The usb config is per-variant, this needs to go in overridetree. I have some patches coming to define all the usb ports.

Hi Ducan, gpio-reset using A-13 across all TGL variants. cant we place in baseboard? Overridetree from each platform is must? pls provide the feedback.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 16:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

5:53 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 6:

...

Patch Set 6:

...
Patch Set 6: Code-Review-1

The usb config is per-variant, this needs to go in overridetree. I have some patches coming to define all the usb ports.

Hi Ducan, gpio-reset using A-13 across all TGL variants. cant we place in baseboard? Overridetree from each platform is must? pls provide the feedback.

The USB port setup is not the same across all variants (it is for BT but not the other ports) so it needs to go in overridetree. as mentioned I have some patches coming to configure the USB ACPI for all variants.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 16:53:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaunak Saha (Code Review)

6:20 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 6:

...

Patch Set 6:

...
Patch Set 6:

...
Patch Set 6: Code-Review-1

The usb config is per-variant, this needs to go in overridetree. I have some patches coming to define all the usb ports.

Hi Ducan, gpio-reset using A-13 across all TGL variants. cant we place in baseboard? Overridetree from each platform is must? pls provide the feedback.

The USB port setup is not the same across all variants (it is for BT but not the other ports) so it needs to go in overridetree. as mentioned I have some patches coming to configure the USB ACPI for all variants.

Agreed. Will put this change on override for every variant.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 6 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 17:20:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaunak Saha (Code Review)

8:41 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Hello build bot (Jenkins), Caveh Jalali, Duncan Laurie, Tim Wawrzynczak, Nick Vaccaro, Tim Wawrzynczak, Sukumar Ghorai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46825

to look at the new patch set (#7).

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

mb/google/volteer: provide gpio-reset interface for Bluetooth reset

BUG=b:171085081 TEST= Verify kernel log "usb 3-10: GPIO lookup for consumer reset" on Delbin

Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/boldar/overridetree.cb M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/eldrid/overridetree.cb M src/mainboard/google/volteer/variants/elemi/overridetree.cb M src/mainboard/google/volteer/variants/halvor/overridetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb M src/mainboard/google/volteer/variants/malefor/overridetree.cb M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb M src/mainboard/google/volteer/variants/trondo/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 14 files changed, 144 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/46825/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 7 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Duncan Laurie (Code Review)

9:01 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 7:

Here is the patches I mentioned that define all the usb ports for each variant: https://review.coreboot.org/c/coreboot/+/46853

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 7 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:01:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaunak Saha (Code Review)

10:57 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 7:

...

Patch Set 7:

Here is the patches I mentioned that define all the usb ports for each variant: https://review.coreboot.org/c/coreboot/+/46853

Thanks Duncan. I see you used aliases for usb ports and root hub. So if i make this depend on your CL this should be: device ref south_xhci on chip drivers/usb/acpi device xhci_root_hub on chip drivers/usb/acpi register "desc" = ""Integrated CnVi bluetooth"" register "reset_gpio" = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device usb2_port10 on end end end end end Shall i go ahead with the change above? please suggest.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 7 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 21:57:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

28 Oct 28 Oct

12:10 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 7:

Hi Shaunak, please see CB:46853

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 7 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 23:10:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaunak Saha (Code Review)

1:27 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Patch Set 7:

...

Patch Set 7:

Hi Shaunak, please see CB:46853

Thanks Tim and Duncan. I will abandon this patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 7 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Oct 2020 00:27:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shaunak Saha (Code Review)

1:28 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: provide gpio-reset interface for Bluetooth reset

Shaunak Saha has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46825 )

Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................

Abandoned

changes incorporated in https://review.coreboot.org/c/coreboot/+/46853/

-- To view, visit https://review.coreboot.org/c/coreboot/+/46825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8 Gerrit-Change-Number: 46825 Gerrit-PatchSet: 7 Gerrit-Owner: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1547

days inactive

1549

days old

coreboot-gerrit@coreboot.org

20 comments

4 participants

tags (0)

participants (4)

Duncan Laurie (Code Review)
Shaunak Saha (Code Review)
Sukumar Ghorai (Code Review)
Tim Wawrzynczak (Code Review)